Re: [PATCH] selftests/alsa: Fix format specifier and function mismatch in mixer-test

[Takashi Iwai]

On Sun, 05 Jul 2026 19:10:38 +0200,
Malaya Kumar Rout wrote:
> 
> In the ctl_value_index_valid() function, when validating 64-bit integer
> controls (SND_CTL_ELEM_TYPE_INTEGER64), the error message for maximum
> value validation has two bugs:
> 
> 1. Uses snd_ctl_elem_info_get_max() instead of the 64-bit variant
>    snd_ctl_elem_info_get_max64()
> 2. Uses %ld format specifier instead of %lld for long long type
> 
> This is inconsistent with the minimum value validation (line 335-339)
> which correctly uses get_min64() and %lld. The mismatch can cause:
> - Incorrect maximum values being reported on some architectures
> - Undefined behavior due to format specifier mismatch
> - Potential crashes when printing the error message
> 
> Fix by using snd_ctl_elem_info_get_max64() and %lld format specifier
> to match the data type and be consistent with the minimum value check.
> 
> Signed-off-by: Malaya Kumar Rout <malayarout91@xxxxxxxxx>

Thanks, applied now.


Takashi