Re: [PATCH 13/24] ASoC: codecs: cs35l56: Use guard() and PM runtime scope helpers

From: Bui Duc Phuc

Date: Mon Jul 06 2026 - 07:45:17 EST


Hi Richard,

Thank you for your review.

>
> Should change all the error returns to directly return IRQ_NONE.
> It looks like a bug that it checks rv but returns ret.
>
> The reason for ret was so it could use common exit code to
> pm_runtime_put() and mutex_unlock() for the error and success cases.
> But this isn't needed now.
>
> The local ret variable can be deleted.
>

I sent a v2 a few days ago.
https://lore.kernel.org/all/20260703055355.244898-1-phucduc.bui@xxxxxxxxx/
Could you please take a look and review it as well?
If there are any remaining issues, I'll address them and send a v3.

Best regards,
Phuc