Re: [PATCH net-next v6 2/5] dpll: add DPLL_PIN_TYPE_INT_NCO pin type

[Vadim Fedorenko]

On 06/07/2026 10:31, Paolo Abeni wrote:
> On 6/30/26 2:55 PM, Ivan Vecera wrote:
> > Add DPLL_PIN_TYPE_INT_NCO pin type for virtual pins representing
> > the NCO mode of a DPLL. When connected as a DPLL input, the DPLL
> > enters NCO mode where the output frequency is adjusted by the host
> > via the PTP clock interface.
> >
> > Update the fractional-frequency-offset and fractional-frequency-
> > offset-ppt attribute documentation to note that for INT_NCO pins
> > these attributes represent the DPLL's current output frequency
> > offset from its nominal frequency.
> >
> > Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxx>
> > Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx>
>
> @Vadim: it's not clear to me if your doubts over the design choice
> raised in previous iterations are still there. My understanding is there
> is reasonable agreement vs the new pin type, if you have very strong
> objections please raise them soonish.

@Paolo: I still have my doubts here, but the patchset has Rb tags from
Jiri, who is DPLL maintainer as well, so I think it's good to go...