Re: [PATCH] block: split out a new blk_plug.h helper
From: Christoph Hellwig
Date: Mon Jul 06 2026 - 08:06:32 EST
On Mon, Jul 06, 2026 at 04:04:48PM +0900, Damien Le Moal wrote:
> > +#include <linux/sched.h>
>
> struct blk_plug_cb has a list_head. So maybe also add
>
> #include <linux/types.h>
>
> ?
That already gets pulled in.
> > +
> > +struct blk_plug_cb;
>
> Maybe add "struct request;" here too ?
No need for type forward declarations when the types are only used
for pointers in structs (or as pointer variables). They are needed
only when pointers to the type are used in prototypes.