Re: [PATCH v4 1/5] media: qcom: camss: Populate CAMSS child devices via DT

[Bryan O'Donoghue]

On 06/07/2026 13:09, Krzysztof Kozlowski wrote:
> On 06/07/2026 09:11, Atanas Filipov wrote:
> > From: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> >
> > Use devm_of_platform_populate() so that child nodes declared under the
> > CAMSS device tree node (e.g. OPE) are automatically instantiated as
> > platform devices. This is required now that CAMSS is modelled as a
> > simple-bus and ISP blocks such as OPE are described as child nodes.
>
> I do not understand this rationale. How is this required now? Are
> existing DTS broken and do not work? Then this needs to be explained.

Required is wrong, true. Existing DT is not broken no.

Should read something like:

"Use devm_of_platform_populate() so that child nodes declared under the 
CAMSS device tree node (e.g. OPE) are automatically instantiated as 
platform devices."

Why this patch ? We also discussed simple-mfd but then settled on this 
way instead.

https://lore.kernel.org/all/0f898ad3-156d-496c-b2c1-88646edc7ab6@xxxxxxxxxx/

> Best regards,
> Krzysztof

Not withstanding this series, I'll fixup my version of this patch ;)

---
bod