Re: [PATCH 0/6] Return -ENODEV instead of -EFAULT on module-get failure

[Bui Duc Phuc]

Hi Cezary,

Thank you for your review.

> > No functional change is intended.
> Changing a return code _is_ a functional change, so the last statement
> is bogus.
>

Agreed, will fix the commit message.

> Now, there is a benefit of having a different error code in
> try_module_get() case: easier to find the offending bit when viewing
> logs.  All the functions in the area have rather low log-coverage so
> distinct error codes help.
>
> Regardless, as you mentioned, -EFAULT isn't exactly the right return
> code either so the direction of the patchset is good.

Should I also add dev_err() at these paths, or is the distinct error
code enough for now?

Best regards,
Phuc