Re: [PATCH net-next v3 1/2] net/sched: sch_fq_pie: add per-flow statistics via class ops

[Paolo Abeni]

On 6/30/26 8:37 PM, Hemendra M. Naik wrote:
> diff --git a/net/sched/sch_fq_pie.c b/net/sched/sch_fq_pie.c
> index 72f48fa4010b..60e85c002ae7 100644
> --- a/net/sched/sch_fq_pie.c
> +++ b/net/sched/sch_fq_pie.c
> @@ -330,7 +330,7 @@ static int fq_pie_change(struct Qdisc *sch, struct nlattr *opt,
>  	/* tupdate is in jiffies */
>  	if (tb[TCA_FQ_PIE_TUPDATE])
>  		WRITE_ONCE(q->p_params.tupdate,
> -			usecs_to_jiffies(nla_get_u32(tb[TCA_FQ_PIE_TUPDATE])));
> +			   usecs_to_jiffies(nla_get_u32(tb[TCA_FQ_PIE_TUPDATE])));

Minor nit, only if a repost is needed for other reasons: unrelated
formatting changes should go in a separate patch.

> @@ -517,10 +519,10 @@ static int fq_pie_dump_stats(struct Qdisc *sch, struct gnet_dump *d)
>  	st.packets_in	= q->stats.packets_in;
>  	st.overlimit	= q->stats.overlimit;
>  	st.overmemory	= q->overmemory;
> -	st.dropped	= q->stats.dropped;
> -	st.ecn_mark	= q->stats.ecn_mark;
> -	st.new_flow_count = q->new_flow_count;
> -	st.memory_usage   = q->memory_usage;
> +	st.dropped		= q->stats.dropped;
> +	st.ecn_mark		= q->stats.ecn_mark;
> +	st.new_flow_count	= q->new_flow_count;
> +	st.memory_usage	= q->memory_usage;

Same here.

@Jamal: the patch LGTM, and I think that the alignment concern raised by
sashiko is not relevant:

https://sashiko.dev/#/patchset/20260630183702.170798-1-hemendranaik%40gmail.com

as user-space already has to deal with 64-bit aligned fields in tc stats.

WDYT?

Thanks,

Paolo