Re: [PATCH] can: ctucanfd: add missing MODULE_DEVICE_TABLE()

[Pavel Pisa]

Dear Pengpeng Hou,

thanks for catching out omission.

On Saturday 04 of July 2026 17:19:57 Pengpeng Hou wrote:
> The driver has a match table for the pci bus wired into its driver
> structure, but the table is not exported with MODULE_DEVICE_TABLE().
>
> Add the missing MODULE_DEVICE_TABLE() entry so module alias information
> is generated for automatic module loading.
>
> This is a source-level fix.  It does not claim dynamic hardware
> reproduction; the evidence is the driver-owned match table, its use by
> the driver registration structure, and the missing module alias
> publication.
>
> Signed-off-by: Pengpeng Hou <pengpeng@xxxxxxxxxxx>

Acked-by: Pavel Pisa <pisa@xxxxxxxxxxx>

> ---
>  drivers/net/can/ctucanfd/ctucanfd_pci.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/can/ctucanfd/ctucanfd_pci.c
> b/drivers/net/can/ctucanfd/ctucanfd_pci.c index 7b847b667973..c2b9bce7c2c6
> 100644
> --- a/drivers/net/can/ctucanfd/ctucanfd_pci.c
> +++ b/drivers/net/can/ctucanfd/ctucanfd_pci.c
> @@ -274,6 +274,7 @@ static const struct pci_device_id ctucan_pci_tbl[] = {
>  		CTUCAN_WITH_CTUCAN_ID)},
>  	{},
>  };
> +MODULE_DEVICE_TABLE(pci, ctucan_pci_tbl);
>
>  static struct pci_driver ctucan_pci_driver = {
>  	.name = KBUILD_MODNAME,


                Pavel Pisa
    phone:      +420 603531357
    e-mail:     pisa@xxxxxxxxxxxxxxxx
    Department of Control Engineering FEE CVUT
    Karlovo namesti 13, 121 35, Prague 2
    university: http://control.fel.cvut.cz/
    personal:   http://cmp.felk.cvut.cz/~pisa
    social:     https://social.kernel.org/ppisa
    projects:   https://www.openhub.net/accounts/ppisa
    CAN related:http://canbus.pages.fel.cvut.cz/
    RISC-V education: https://comparch.edu.cvut.cz/
    Open Technologies Research Education and Exchange Services
    https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home