Re: [PATCH v2 03/24] ASoC: codecs: arizona-jack: Use guard() cleanup helpers
From: Charles Keepax
Date: Mon Jul 06 2026 - 09:11:35 EST
On Fri, Jul 03, 2026 at 12:53:34PM +0700, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> Clean up the code using guard() helpers for mutex locking
> and PM runtime management.
> No functional change intended.
>
> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
> ---
> @@ -1119,9 +1112,6 @@ static irqreturn_t arizona_jackdet(int irq, void *data)
> ARIZONA_JD1_FALL_TRIG_STS |
> ARIZONA_JD1_RISE_TRIG_STS);
>
> - mutex_unlock(&info->lock);
> -
> - pm_runtime_put_autosuspend(arizona->dev);
>
> return IRQ_HANDLED;
Minor nit, this leaves a double blank line here.
Otherwise looks good to me:
Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
Thanks,
Charles