Re: [PATCH 14/19] ASoC: codecs: wm8962: Propagate regcache_sync() errors

[Mark Brown]

On Mon, Jul 06, 2026 at 10:11:35AM +0100, Richard Fitzgerald wrote:
> On 04/07/2026 5:02 am, Pengpeng Hou wrote:

> > @@ -3955,6 +3957,11 @@ static int wm8962_runtime_resume(struct device *dev)
> >   	return 0;
> > +cache_sync_err:

> Should this error path revert the three regmap writes that were done
> before the regcache_sync() ?

Possibly, OTOH if the sync is failing we probably have I/O issues and
it's questionable if the revert will work.  We also don't know how much
of the sync actually happened so that's a thing too.  I suggest not
worrying too much about it until we've got an actual use case where
sensible recovery is plausible.

Attachment: signature.asc
Description: PGP signature