Re: [PATCH v3 2/3] media: iris: Add support for Milos (VPU v2.0)

[Dmitry Baryshkov]

On Sun, Jul 05, 2026 at 10:10:35AM +0000, Alexander Koskovich wrote:
> Add support for the Milos Iris codec. This only supports the variant
> found on the SM7635-AB that has half of it's pipes disabled via efuse.
> 
> Signed-off-by: Alexander Koskovich <akoskovich@xxxxx>
> ---
>  drivers/media/platform/qcom/iris/iris_hfi_gen2.c   | 883 +++++++++++++++++++++
>  .../platform/qcom/iris/iris_platform_common.h      |   2 +
>  .../media/platform/qcom/iris/iris_platform_milos.h |  28 +
>  .../media/platform/qcom/iris/iris_platform_vpu2.c  |  35 +
>  drivers/media/platform/qcom/iris/iris_probe.c      |   4 +
>  5 files changed, 952 insertions(+)
> 
>  
> +static const struct iris_firmware_desc iris_milos_desc = {
> +	.firmware_data = &iris_hfi_milos_data,
> +	.get_vpu_buffer_size = iris_vpu_buf_size,
> +	.fwname = "qcom/vpu/vpu20_p2.mbn",

Nit, please use vpu20_p2_gen2.mbn at least (or, better,
qcom/vpu/vpu20_p2_gen2_s6.mbn or _s7, depending on the MBN signature).
It won't work with gen1 vpu20_p2.mbn.

Otherwise, looks good to me.

> +};
> +
>  static const struct iris_firmware_desc iris_vpu20_p1_gen1_desc = {
>  	.firmware_data = &iris_hfi_gen1_data,
>  	.get_vpu_buffer_size = iris_vpu_buf_size,

-- 
With best wishes
Dmitry