Re: [PATCH net-next 1/2] net: phy: ax88796b: Use vertical import style

From: Andrew Lunn

Date: Mon Jul 06 2026 - 10:41:56 EST


On Sun, Jul 05, 2026 at 10:38:40PM -0700, Guru Das Srinagesh wrote:
> Convert `use` imports to vertical layout for better readability and
> maintainability.
>
> Signed-off-by: Guru Das Srinagesh <linux@xxxxxxxxxxx>
> ---
> drivers/net/phy/ax88796b_rust.rs | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/ax88796b_rust.rs b/drivers/net/phy/ax88796b_rust.rs
> index 2d24628a4e58..5a21fe09bd62 100644
> --- a/drivers/net/phy/ax88796b_rust.rs
> +++ b/drivers/net/phy/ax88796b_rust.rs
> @@ -5,7 +5,12 @@
> //!
> //! C version of this driver: [`drivers/net/phy/ax88796b.c`](./ax88796b.c)
> use kernel::{
> - net::phy::{self, reg::C22, DeviceId, Driver},
> + net::phy::{
> + self,
> + reg::C22,
> + DeviceId,
> + Driver, //
> + },

A question from somebody who does not know rust. Does the order of the
elements in the list matter?

Linux has a pattern of sorting multi line lists, because it reduces
merge conflicts. Can this list be sorted?

Andrew