Re: [PATCH 3/3] null_blk: register configfs subsystem after creating default devices

From: Bart Van Assche

Date: Mon Jul 06 2026 - 10:58:55 EST


On 7/6/26 5:35 AM, Zizhi Wo wrote:
@@ -2187,8 +2185,6 @@ static int __init null_init(void)
null_destroy_dev(nullb);
}
unregister_blkdev(null_major, "nullb");
-err_conf:
- configfs_unregister_subsystem(&nullb_subsys);
return ret;
}

Please make null_exit() consistent with the cleanup path in null_init().
null_exit() calls unregister_blkdev() before it destroys the null_blk
instances. That doesn't look right to me.

Thanks,

Bart.