Re: [PATCH] scsi: sg: report request-table problems when any status is set

[Bart Van Assche]

On 7/6/26 1:44 AM, raoxu wrote:
> From: Xu Rao <raoxu@xxxxxxxxxxxxx>
>
> SG_GET_REQUEST_TABLE reports per-request diagnostic state through
> sg_req_info::problem. The field is meant to indicate whether there is
> an error to report for a completed request.
>
> sg_fill_request_table() currently combines masked_status, host_status
> and driver_status with bitwise AND. This only reports a problem when all
> three status fields are non-zero at the same time. A normal target check
> condition, for example, has masked_status set while host_status and
> driver_status may both be zero, so the request is incorrectly reported
> as clean.
>
> Use the same condition as sg_new_read(), which sets SG_INFO_CHECK when
> any of the three status fields is non-zero.
>
> Signed-off-by: Xu Rao <raoxu@xxxxxxxxxxxxx>
> ---
>   drivers/scsi/sg.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
> index 74cd4e8a61c2..5408f002e6c0 100644
> --- a/drivers/scsi/sg.c
> +++ b/drivers/scsi/sg.c
> @@ -863,10 +863,9 @@ sg_fill_request_table(Sg_fd *sfp, sg_req_info_t *rinfo)
>   		if (val >= SG_MAX_QUEUE)
>   			break;
>   		rinfo[val].req_state = srp->done + 1;
> -		rinfo[val].problem =
> -			srp->header.masked_status &
> -			srp->header.host_status &
> -			srp->header.driver_status;
> +		rinfo[val].problem = srp->header.masked_status ||
> +					     srp->header.host_status ||
> +					     srp->header.driver_status;
>   		if (srp->done)
>   			rinfo[val].duration =
>   				srp->header.duration;

A "Cc: stable" tag is missing. Otherwise this patch looks good to me.

Thanks,

Bart.