Re: [PATCH net-next 2/2] net: phy: qt2025: Use vertical import style

From: Miguel Ojeda

Date: Mon Jul 06 2026 - 12:39:04 EST


On Mon, Jul 6, 2026 at 5:51 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> How often does the style edition change? Is there a 2026? How much
> changes in each one?

Every 3 years or so. For 2024, not much changes -- you can easily try
yourself passing the `--style-edition` flag. From a quick look, it is
almost all just the import sorting:

https://doc.rust-lang.org/style-guide/editions.html

> features. Style patches are mostly a waste of reviewer/maintainer
> time, because some actually break stuff, so need to be reviewed just

Yes, we don't particularly like those either, but this is not like
those: it is not a manual process, and very, very unlikely to
functionally break anything (and trivially reviewed, from my
inspection above).

Just to clarify further: if we decided to do this, which is not a
given, this would be a treewide change done at once (because
formatting is enforced treewide), and nothing you would need to
review.

Cheers,
Miguel