[PATCH 0/2] minix: modernize function declarations and eliminating some magic numbers

From: Jeremy Bingham

Date: Mon Jul 06 2026 - 14:24:56 EST


Another set of minix patches fixing issues that I noticed while working
on other things. The various dirsize and namelen values being set in
minix_fill_super() in inode.c, which vary depending on the versions of
the minix filesystem and how it was created, were being set as magic
numbers. The function declarations in minix.h were also a mix of current
and historic kernel coding standards, where some function declarations
had arguments with types and names while others had only types. This
became an annoyance when updating minix.h because checkpatch.pl would
gripe about improper function declarations.

Create and use #defines for the various dirsize and namelen values in
minix_fill_super, and modernize the function declarations in minix.h.

Both patches have been tested by mounting and performing file operations
against v1, v2, and v3 minix filesystem volumes. Neither of them have
any functional changes.

Jeremy Bingham (2):
minix: define constants for dirsize and namelen
minix: modernize function declarations in minix.h

fs/minix/inode.c | 20 ++++++------
fs/minix/itree_v1.c | 2 +-
fs/minix/itree_v2.c | 2 +-
fs/minix/minix.h | 78 ++++++++++++++++++++++++++++++---------------
4 files changed, 65 insertions(+), 37 deletions(-)

--
2.47.3