Re: [PATCH RESEND] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE
From: Krzysztof Kozlowski
Date: Mon Jul 06 2026 - 15:11:07 EST
On 06/07/2026 19:13, Bartosz Golaszewski wrote:
> On Mon, 6 Jul 2026 08:54:22 +0200, Krzysztof Kozlowski <krzk@xxxxxxxxxx> said:
>> On Sun, Jul 05, 2026 at 11:15:45PM +0530, Kuldeep Singh wrote:
>>> On 04-07-2026 06:14, Shawn Guo wrote:
>>>> Document Inline Crypto Engine (ICE) on Qualcomm Nord SoC.
>>>>
>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>>>> Reviewed-by: Harshal Dev <harshal.dev@xxxxxxxxxxxxxxxx>
>>>> Signed-off-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
>>>> ---
>>>> It was included in the Nord SA8797P DTS series [1] due to that
>>>> the prerequisite changes were picked up by Bjorn for 7.2. Resend it to
>>>> Herbert as the dependency is gone now with 7.2-rc1.
>>>>
>>>> [1] https://lore.kernel.org/all/20260526051300.1669201-1-shengchao.guo@xxxxxxxxxxxxxxxx/
>>>>
>>>> .../devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
>>>> index db895c50e2d2..d690eff2e86d 100644
>>>> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
>>>> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
>>>> @@ -17,6 +17,7 @@ properties:
>>>> - qcom,hawi-inline-crypto-engine
>>>> - qcom,kaanapali-inline-crypto-engine
>>>> - qcom,milos-inline-crypto-engine
>>>> + - qcom,nord-inline-crypto-engine
>>>> - qcom,qcs8300-inline-crypto-engine
>>>> - qcom,sa8775p-inline-crypto-engine
>>>> - qcom,sc7180-inline-crypto-engine
>>>> @@ -63,6 +64,7 @@ allOf:
>>>> enum:
>>>> - qcom,eliza-inline-crypto-engine
>>>> - qcom,milos-inline-crypto-engine
>>>> + - qcom,nord-inline-crypto-engine
>>>
>>> With below patch, we don't need nord entry here.
>>> https://lore.kernel.org/lkml/20260702-b4-shikra_crypto_changse-v2-1-66173f2f28b3@xxxxxxxxxxxxxxxx/
>>
>> Patch has conflict. This (Nord) should go after above one, with this
>> fixed.
>>
>
> The other series still hasn't made its way upstream. This one's simple, can we
> queue it now and rebase the other one?
This is not point of rebase, but conflicting work.
Best regards,
Krzysztof