Re: [PATCH v13 14/15] barrier: add tests for smp_cond_load_*_timeout()

[Ankur Arora]

Julian Braha <julianbraha@xxxxxxxxx> writes:

> Hi Ankur,
>
> On 7/2/26 02:33, Ankur Arora wrote:
>> +config BARRIER_TIMEOUT_TEST
>> +	tristate "KUnit tests for smp_cond_load_relaxed_timeout()"
>> +	depends on KUNIT
>> +	default KUNIT_ALL_TESTS
>> +	help
>> +	  Builds KUnit tests that validate wake-up and timeout handling paths
>> +	  in smp_cond_load_relaxed_timeout().
>> +
>> +	  Say N if you are unsure.
>
> Could you follow the kunit documentation for the kconfig entry:
> Documentation/dev-tools/kunit/style.rst
>
> Specifically, these two guidelines:
> 1. "be named CONFIG_<name>_KUNIT_TEST: where <name> is the name of the
> test suite."
> 2. be visible only if CONFIG_KUNIT_ALL_TESTS is not enabled.

Sorry had missed that. Will change to something like the following:

+config BARRIER_TIMEOUT_KUNIT_TEST
+       tristate "KUnit tests for smp_cond_load_relaxed_timeout()" if !KUNIT_ALL_TESTS
+       depends on KUNIT
+       default KUNIT_ALL_TESTS
+       help
+         Builds KUnit tests that validate wake-up and timeout handling paths
+         in smp_cond_load_relaxed_timeout().
+
+         If unusure, say N.
+

Thanks for the review.

--
ankur