Re: [PATCH] clk: thead: allow COMPILE_TEST builds
From: Drew Fustini
Date: Mon Jul 06 2026 - 16:32:54 EST
On Mon, Jul 06, 2026 at 01:20:53PM -0400, Brian Masney wrote:
> Hi Rosen,
>
> On Sun, Jun 28, 2026 at 08:28:14PM -0700, Rosen Penev wrote:
> > CLK_THEAD_TH1520_AP already allows COMPILE_TEST, but the parent clock
> > Makefile only descends into drivers/clk/thead for ARCH_THEAD. Use the
> > TH1520 AP clock symbol for the directory gate instead.
> >
> > This lets the driver build on other 64-bit architectures selected for
> > compile testing without selecting the T-HEAD platform.
> >
> > Tested with:
> > make LLVM=1 ARCH=loongarch drivers/clk/thead/
> >
> > Assisted-by: Codex:GPT-5.5
> > Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> > ---
> > drivers/clk/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
> > index 68145ad91035..d651e4ed3462 100644
> > --- a/drivers/clk/Makefile
> > +++ b/drivers/clk/Makefile
> > @@ -157,7 +157,7 @@ obj-$(CONFIG_ARCH_SUNXI) += sunxi/
> > obj-y += sunxi-ng/
> > obj-$(CONFIG_CLK_TEGRA) += tegra/
> > obj-y += tenstorrent/
> > -obj-$(CONFIG_ARCH_THEAD) += thead/
> > +obj-$(CONFIG_CLK_THEAD_TH1520_AP) += thead/
>
> Right now, CLK_THEAD_TH1520_AP is the only Kconfig defined in the thead
> subdirectory. What about when/if someone adds a second Kconfig, and
> that's the only one that's enabled?
>
> Would it be better to have this as obj-y?
>
> Brian
I think obj-y would make sense. AP is just one of several TH1520 SoC
subsystems with a clock controller. Support may some day be added for
the other controllers.
Thanks,
Drew