Re: [PATCH v2] clk/ingenic: fix clock leak on clk_register_clkdev failure

[Brian Masney]

On Sun, Jun 28, 2026 at 08:28:11PM +0800, WenTao Liang wrote:
> clk_register() succeeds but clk_register_clkdev() fails, and the error
> path jumps to out without calling clk_unregister or clk_put to release
> the registered clock. This leaks the clock object within the common clock
> framework


> , contrasting with the CGU_CLK_EXT type path which correctly
> calls clk_put on error.

I would drop this part. Just focus on what you are fixing.

> 
> Suggested-by: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>

I don't see where on the v1 Greg suggested this, unless I am missing
something?

> Fixes: b066303fb3e7 ("clk: ingenic: add driver for Ingenic SoC CGU clocks")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: WenTao Liang <vulab@xxxxxxxxxxx>
> ---
> Changes in v2:
> - Fix patch format based on reviewer feedback

Link to v1: https://lore.kernel.org/linux-clk/20260626115644.33779-1-vulab@xxxxxxxxxxx/

With those fixes:

Reviewed-by: Brian Masney <bmasney@xxxxxxxxxx>


> ---
>  drivers/clk/ingenic/cgu.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/ingenic/cgu.c b/drivers/clk/ingenic/cgu.c
> index 41e4c69131bd..b59b24d0e3cf 100644
> --- a/drivers/clk/ingenic/cgu.c
> +++ b/drivers/clk/ingenic/cgu.c
> @@ -774,8 +774,10 @@ static int ingenic_register_clock(struct ingenic_cgu *cgu, unsigned idx)
>  	}
>  
>  	err = clk_register_clkdev(clk, clk_info->name, NULL);
> -	if (err)
> +	if (err) {
> +		clk_unregister(clk);
>  		goto out;
> +	}
>  
>  	cgu->clocks.clks[idx] = clk;
>  out:
> -- 
> 2.39.5 (Apple Git-154)
>