Re: [RFC PATCH 3/6] cpufreq/amd-pstate: Repurpose "amd_dynamic_epp" cmdline and corresponding sysfs

[Mario Limonciello]

On 7/2/26 15:36, K Prateek Nayak wrote:
> Hello Mario,
>
> On 7/2/2026 3:10 AM, Mario Limonciello wrote:
> > On 6/30/26 13:59, K Prateek Nayak wrote:
> > > Since dynamic_epp has been converted to an
> > > "energy_performance_preference", toggling the feature via the sysfs file
> > > is now redundant.
> > >
> > > Repurpose "amd_dynamic_epp=enable" command line to opt into dynamic EPP
> > > by default when the active driver is loaded, or switched into. The
> > > "disable" counterpart will "dynamic" option out of
> > > "energyy_performance_preference" to ensure dynamic EPP feature can never
> > > be toggled.
> > >
> > > Use a tri-state enum to differentiate if the user has supplied a command
> > > line parameter or not to enable the feature by default vs keeping the
> > > current defaults as is and allowing users to toggle it later via the
> > > "dynamic" option in "energy_performance_preference" selection.
> > >
> > > Signed-off-by: K Prateek Nayak <kprateek.nayak@xxxxxxx>
> >
> > Honestly - I have to question if we even want to have the kernel command line option anymore.  If userspace can easily opt in and out as in this series, do we still need a kernel command line for default policy?
> >
> > I'm of the opinion rip it out, less to maintain.
>
> Ack! I'll rip out the cmdline and the "dynamic_epp" sysfs file then in
> the next version?

Yeah; I would say so.