Re: [PATCH v4] arm64: dts: qcom: qcom6490-idp: Add IPA nodes

[Bjorn Andersson]

On Fri, Jul 03, 2026 at 02:28:09PM +0530, Sarat Addepalli wrote:
> Add IPA nodes for Qualcomm qcm6490 board.

There's no such thing as "the qcm6490 board" - I have 2 different "the"
qcm6490 boards...

Please start your commit message by describing the "problem" that the
patch is solving. 

> 
> The qcom,gsi-loader and memory-region properties are provided by
> kodiak.dtsi as part of the IPA property consolidation work, so only
> the board-specific firmware-name and status properties need to be set.

That's how DeviceTree source works, no need to document it.

> 
> Link: https://lore.kernel.org/all/20260517-ipa-loader-v1-0-3c3764c1b4a3@xxxxxxxxxxxxxxxx/

In line with Konrad's comment, it's not clear to me what this link is
doing here. Either help me understand (in the commit message) or remove
it.

> Signed-off-by: Sarat Addepalli <sarat.addepalli@xxxxxxxxxxxxxxxx>
> ---
> Changes in v4:
> - Removed empty line between Link and Signed-off-by tags.
> - Added empty line before the status property in the IPA node.
> - Sent as a new thread instead of replying to the previous revision.
> Changes in v3:
> - Rebased on top of IPA property consolidation series.
> - Dropped qcom,gsi-loader and memory-region properties as they are now
>   provided by kodiak.dtsi.
> - Added Link tag to the dependent IPA loader series.
> Changes in v2:
> - Modified firmware file extension from .mdt to .mbn
> 
> v3: https://lore.kernel.org/all/20260702105509.1360340-1-sarat.addepalli@xxxxxxxxxxxxxxxx/
> v2: https://lore.kernel.org/all/20260618124700.2001191-1-sarat.addepalli@xxxxxxxxxxxxxxxx/
> v1: https://lore.kernel.org/all/20250304152133.GA2763820@xxxxxxxxxxxxxxxxxxxxxxxxxxxx/
> 
>  arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index bdc02260f902..7242695aed97 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -619,6 +619,12 @@ &gpu_zap_shader {
>  	firmware-name = "qcom/qcm6490/a660_zap.mbn";
>  };
>  
> +&ipa {
> +	firmware-name = "qcom/qcm6490/ipa_fws.mbn";
> +
> +	status = "okay";
> +};
> +
>  &lpass_rx_macro {
>  	status = "okay";
>  };