Re: [PATCH 2/9] dt-bindings: PCI: qcom: Document the Shikra PCIe Controller

[Sushrut Shree Trivedi]

On 7/1/2026 11:56 AM, Krzysztof Kozlowski wrote:
> On 30/06/2026 21:02, Sushrut Shree Trivedi wrote:
> > Add a dedicated schema for the PCIe controller found on the Shikra
> > platform.
> >
> > Signed-off-by: Sushrut Shree Trivedi <sushrut.trivedi@xxxxxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/pci/qcom,shikra-pcie.yaml  | 211 +++++++++++++++++++++
> >   1 file changed, 211 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/qcom,shikra-pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,shikra-pcie.yaml
> > new file mode 100644
> > index 000000000000..f9d1dba9dd2e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pci/qcom,shikra-pcie.yaml
> > @@ -0,0 +1,211 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pci/qcom,shikra-pcie.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Shikra PCI Express Root Complex
> > +
> > +maintainers:
> > +  - Bjorn Andersson <andersson@xxxxxxxxxx>
> > +  - Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> > +
> > +description:
> > +  Qualcomm Shikra SoC (and compatible) PCIe root complex controller is based on
> > +  the Synopsys DesignWare PCIe IP.
> > +
> > +properties:
> > +  compatible:
> > +    const: qcom,shikra-pcie
> > +
> > +  reg:
> > +    minItems: 5
> > +    maxItems: 6
> Same comments as other recent Qualcomm bindings. Don't invent stuff,
> take what was reviewed from the list so we won't have to repeat.
>
> ...
ACK'd. Will use latest binding patches as reference in v2.
> > +          power-domains = <&gcc GCC_PCIE_GDSC>;
> > +
> > +          max-link-speed = <2>;
> > +
> > +          operating-points-v2 = <&pcie_opp_table>;
> > +
> > +          status = "disabled";
> Drop, you never tested the binding in such case.
ACK'd.
> > +
> > +          pcie_opp_table: opp-table {
> > +                  compatible = "operating-points-v2";
> Broken indent.
ACK'd.
> > +
> > +                  /* GEN 1 x1 */
> > +                  opp-2500000 {
> > +                          opp-hz = /bits/ 64 <2500000>;
> > +                          required-opps = <&rpmpd_opp_nom>;
> > +                          opp-peak-kBps = <250000 1>;
> > +                          opp-level = <1>;
> > +                  };
> > +
> > +                  /* GEN 2 x1 */
> > +                  opp-5000000 {
> > +                          opp-hz = /bits/ 64 <5000000>;
> > +                          required-opps = <&rpmpd_opp_nom>;
> > +                          opp-peak-kBps = <500000 1>;
> > +                          opp-level = <2>;
> > +                  };
> > +          };
> > +        };
> > +    };
>
> Best regards,
> Krzysztof
Sushrut