Re: [PATCH v2 0/2] mfd: ucb1x00: Convert Assabet gpio-keys to software nodes

[Bartosz Golaszewski]

On Tue, 7 Jul 2026 07:01:29 +0200, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> said:
> This patch series converts the legacy gpio-keys platform device on the
> StrongARM SA-1100 Assabet evaluation board from platform data to software
> nodes and device properties.
>
> The first patch registers a shared software node for the UCB1x00 GPIO
> controller in drivers/mfd/ucb1x00-core.c, attaching its firmware node
> directly to the GPIO chip prior to registration. The second patch
> converts the Assabet machine subdriver to define dynamically allocated
> software nodes referencing the UCB1x00 GPIO controller directly, allowing
> pin bindings to be resolved via the attached firmware node without relying
> on name matching.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---
> Changes in v2:
> - Export ucb1x00_gpiochip_node to fix link errors when built as module.
> - Fix teardown order in core driver to avoid software node use-after-free.
> - Convert Assabet subdriver to use dynamically allocated software nodes
>   to avoid use-after-free on module unload.
> - Factor out button node removal logic into a helper.
> - Link to v1: https://patch.msgid.link/20260706-ucb1x00-assabet-swnode-v1-0-6102eabd31d0@xxxxxxxxx
>
> ---
> Dmitry Torokhov (2):
>       mfd: ucb1x00: Register software node for GPIO controller
>       mfd: ucb1x00: Convert Assabet gpio-keys to use software nodes
>
>  drivers/mfd/ucb1x00-assabet.c | 124 +++++++++++++++++++++++++++++++++---------
>  drivers/mfd/ucb1x00-core.c    |  16 +++++-
>  include/linux/mfd/ucb1x00.h   |   3 +
>  3 files changed, 116 insertions(+), 27 deletions(-)
> ---
> base-commit: 8e9685d3c41c35dd1b37df70d854137abcb2fbac
> change-id: 20260705-ucb1x00-assabet-swnode-683cb383d398
>
> Thanks.
>
> --
> Dmitry
>
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>