Re: [PATCH v5 1/3] dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support

[Krzysztof Kozlowski]

On 07/07/2026 10:08, Daniel Lezcano wrote:
> On 7/7/26 08:38, Krzysztof Kozlowski wrote:
>> On Mon, Jul 06, 2026 at 08:46:46PM +0200, Daniel Lezcano wrote:
>>> Document the Lenovo ThinkPad T14s Embedded Controller as a thermal
>>> sensor provider by adding the '#thermal-sensor-cells' property.
>>>
>>> This allows the EC temperature sensors to be referenced from thermal
>>> zones in the device tree.
>>>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxxxxxxxx>
>>> ---
>>>   .../embedded-controller/lenovo,thinkpad-t14s-ec.yaml         | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml
>>> index c87ccb5b3086..0d049979e35b 100644
>>> --- a/Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml
>>> +++ b/Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml
>>> @@ -26,10 +26,14 @@ properties:
>>>   
>>>     wakeup-source: true
>>>   
>>> +  "#thermal-sensor-cells":
>>> +    const: 1
>>> +
>>>   required:
>>>     - compatible
>>>     - reg
>>>     - interrupts
>>> +  - "#thermal-sensor-cells"
>>
>> This looks like ABI break without explanation.
> 
> What would you suggest ? explanation or removed from required properties?

I don't know what is the explanation. If this is actual ABI break as I
read Linux code, what is the rationale behind breaking real users?

Best regards,
Krzysztof