Re: [PATCH v4 2/3] arm64: dts: qcom: fix SoCCP memory mappings for Glymur
From: Ananthu C V
Date: Tue Jul 07 2026 - 04:46:37 EST
Hi Bjorn,
On Sun, Jul 05, 2026 at 05:27:50PM -0500, Bjorn Andersson wrote:
> On Fri, Jul 03, 2026 at 05:31:12AM -0700, Ananthu C V wrote:
> > Fixup the SoCCP/SoCCP DTB memory regions to reflect the memory
> > region requirements of the SoCCP firmware, as described in the
> > Glymur v21 memory map release.
>
> Please change your commit message to start with a problem description,
> not the action taken by the patch.
ACK, will update.
> > Signed-off-by: Ananthu C V <ananthu.cv@xxxxxxxxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/qcom/glymur.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> > index 20b49af7298e..5f44f68efde2 100644
> > --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
> > @@ -602,13 +602,13 @@ spss_region_mem: spss@88a00000 {
> > no-map;
> > };
> >
> > - soccpdtb_mem: soccpdtb@892e0000 {
> > - reg = <0x0 0x892e0000 0x0 0x20000>;
> > + soccpdtb_mem: soccpdtb@89200000 {
> > + reg = <0x0 0x89200000 0x0 0x20000>;
> > no-map;
> > };
> >
> > - soccp_mem: soccp@89300000 {
> > - reg = <0x0 0x89300000 0x0 0x400000>;
> > + soccp_mem: soccp@88e00000 {
>
> Now the sort order is wrong.
This also will be fixed in the next revision.
> Regards,
> Bjorn
Once again, thanks for the reviews.
Best,
Ananthu