Re: [PATCH] Revert "dt-bindings: i2c: Describe SA8255p"
From: Shawn Guo
Date: Tue Jul 07 2026 - 04:47:42 EST
On Tue, Jul 07, 2026 at 10:08:09AM +0200, Krzysztof Kozlowski wrote:
> On 07/07/2026 10:02, Shawn Guo wrote:
> > This reverts commit fd359c0272bb4078f3a7ef34c1d53ee0deb59900.
> >
> > Compatible "qcom,sa8255p-geni-i2c" had already been defined by
> > soc/qcom/qcom,sa8255p-geni-se-qup.yaml. Revert the change to avoid the
> > same compatible being defined by two bindings.
>
> This makes no sense and to prove it: are you going to revert all such
> bindings, like 100 of them?
Nord compatible "qcom,sa8797p-geni-i2c" was added to
soc/qcom/qcom,sa8255p-geni-se-qup.yaml, as that's where Lemans compatible
"qcom,sa8255p-geni-i2c" is defined. CHECK_DTBS has been working fine by
matching geni-se-qup yaml.
make CHECK_DTBS=y qcom/sa8797p-ride.dtb
Now with this geni-i2c yaml comes in play, CHECK_DTBS finds it instead
and starts complaining about Nord compatible missing there.
DTC [C] arch/arm64/boot/dts/qcom/sa8797p-ride.dtb
arch/arm64/boot/dts/qcom/sa8797p-ride.dtb: i2c@880000 (qcom,sa8797p-geni-i2c): compatible:0: 'qcom,sa8255p-geni-i2c' was expected
from schema $id: http://devicetree.org/schemas/i2c/qcom,sa8255p-geni-i2c.yaml
arch/arm64/boot/dts/qcom/sa8797p-ride.dtb: i2c@880000 (qcom,sa8797p-geni-i2c): compatible: ['qcom,sa8797p-geni-i2c', 'qcom,sa8255p-geni-i2c'] is too long
from schema $id: http://devicetree.org/schemas/i2c/qcom,sa8255p-geni-i2c.yaml
What's your suggestion to fix the problem, add Nord compatible to
geni-se-qup yaml as well?
Shawn