Re: [PATCH] staging: axis-fifo: Fix alignment of wait_event_interruptible arguments

[Greg KH]

On Sat, May 23, 2026 at 03:38:45PM -0400, Pramod Maurya wrote:
> To: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Ovidiu Panait <ovidiu.panait.oss@xxxxxxxxx>
> Cc: Gustavo Piaz da Silva <gustavopiazdasilva2102@xxxxxxxxx>
> Cc: linux-staging@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx

Something went wrong, this shouldn't be in the body of the email :(

> 
> The second argument to wait_event_interruptible() was indented with a
> single tab instead of being aligned to the opening parenthesis. Since
> the fully-aligned form exceeds 80 columns, break the condition at the
> comparison operator and align the continuation line to the opening
> parenthesis.
> 
> Fixes the following checkpatch.pl warning:
>   CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: Pramod Maurya <pramod.nexgen@xxxxxxxxx>
> ---
>  drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 3aa2aa870ea9..1c34de020cf8 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
>  		mutex_lock(&fifo->write_lock);
>  
>  		ret = wait_event_interruptible(fifo->write_queue,
> -			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
> +					       ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >=
> +					       words_to_write);

No, the original is easier to understand, right?

thanks,

greg k-h