Re: [PATCH] staging: rtl8723bs: rename camelcase variable bDumpRxPkt
From: Greg KH
Date: Tue Jul 07 2026 - 06:24:15 EST
On Mon, May 25, 2026 at 12:29:35PM +0530, Anirban Bose wrote:
> Rename the local variable 'bDumpRxPkt' to 'dump_rx_pkt' in
> validate_recv_frame() to resolve a checkpatch.pl CamelCase warning.
>
> Signed-off-by: Anirban Bose <boses156@xxxxxxxxx>
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index 86c5e2c4e7dd..808f67b61f77 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1447,7 +1447,7 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
> u8 type;
> u8 subtype;
> signed int retval = _SUCCESS;
> - u8 bDumpRxPkt;
> + u8 dump_rx_pkt;
>
> struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib;
>
> @@ -1473,7 +1473,7 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
> pattrib->mdata = GetMData(ptr);
> pattrib->privacy = GetPrivacy(ptr);
> pattrib->order = GetOrder(ptr);
> - rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(bDumpRxPkt));
> + rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(dump_rx_pkt));
If this is never used, why is it set at all?
thanks,
greg k-h