Re: [PATCH v2] staging: rtl8723bs: use nl80211_iftype instead of custom NDIS enum

From: Greg KH

Date: Tue Jul 07 2026 - 06:26:45 EST


On Mon, Jun 01, 2026 at 11:10:51PM +0700, Cong Nguyen wrote:
> The driver defined its own enum ndis_802_11_network_infrastructure to
> represent the operating mode (STA/AP/IBSS) and translated nl80211 iftypes
> into it in cfg80211_rtw_change_iface(). The kernel already provides
> enum nl80211_iftype for this purpose, so use it directly and drop the
> redundant translation layer.
>
> Map the removed values as follows:
> Ndis802_11IBSS -> NL80211_IFTYPE_ADHOC
> Ndis802_11Infrastructure -> NL80211_IFTYPE_STATION
> Ndis802_11APMode -> NL80211_IFTYPE_AP
> Ndis802_11AutoUnknown -> NL80211_IFTYPE_UNSPECIFIED
>
> Compile-tested only.
>
> Signed-off-by: Cong Nguyen <congnt264@xxxxxxxxx>
> ---
> Changes in v2:
> - Replace the custom enum ndis_802_11_network_infrastructure with the
> standard enum nl80211_iftype and drop the translation layer, instead
> of just renaming the enum values to uppercase (Greg Kroah-Hartman).
>
> v1: https://lore.kernel.org/linux-staging/20260511134930.4086521-1-congnt264@xxxxxxxxx/

This doesn't apply anymore. Can you rebase it against my
staging-testing branch and resend?

thanks,

greg k-h