[PATCH v4 0/6] rust_binder: update Process::node_refs to use SpinLock
From: Alice Ryhl
Date: Tue Jul 07 2026 - 06:49:22 EST
Unfortunately the current use of a mutex for this lock leads to priority
inversion. Traces have been observed where a process is trying to obtain
this mutex for 22ms, but it's unable to do so because the thread holding
the lock is scheduled out. Since this occurred on a UI thread, that is
an extremely long delay.
This patch series fixes that by first making a series of changes that
remove the possibility of sleeping under the lock, and then finally
changing it to a spinlock.
Based on top of:
https://lore.kernel.org/all/20260707-binder-netlink-v7-0-42b40e4b1ac8@xxxxxxxxxx/
Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
---
Changes in v4:
- Fix conflict with commit bc4a98288978 ("rust_binder: clear freeze listener on node removal")
- Rebase on top of v7.2-rc1 and netlink series.
- Link to v3: https://lore.kernel.org/r/20260615-binder-noderefs-spin-v3-0-3235f5a3e0a0@xxxxxxxxxx
Changes in v3:
- Clone `node` after loop in freeze listener patch.
- Inline `resize_for_add_freeze_listener` in freeze listener patch.
- Pick up Reviewed-by from Matthew.
- Link to v2: https://lore.kernel.org/r/20260609-binder-noderefs-spin-v2-0-eafde2ff376c@xxxxxxxxxx
Changes in v2:
- Make more tweaks to various critical regions and extract them to
separate commits.
- Link to v1: https://lore.kernel.org/r/20260608-binder-noderefs-spin-v1-1-2584cb4e49ff@xxxxxxxxxx
---
Alice Ryhl (6):
rust_binder: avoid allocating under node_refs for freeze listeners
rust_binder: avoid dropping NodeRef in update_ref() under lock
rust_binder: schedule NodeDeath outside of node_refs lock
rust_binder: keep NodeDeath in NodeRefInfo during process cleanup
rust_binder: avoid destructors in insert_or_update_handle()
rust_binder: update Process::node_refs to use SpinLock
drivers/android/binder/freeze.rs | 65 ++++++++++++++++++++++++++-------------
drivers/android/binder/node.rs | 41 ++++++++++++------------
drivers/android/binder/process.rs | 57 ++++++++++++++++++++--------------
3 files changed, 98 insertions(+), 65 deletions(-)
---
base-commit: ffdd0cba394c502b1d7c936586b2a09bb235aa8b
change-id: 20260608-binder-noderefs-spin-3a0ec0589043
Best regards,
--
Alice Ryhl <aliceryhl@xxxxxxxxxx>