Re: [PATCH] staging: rtl8723bs: put logical continuation on previous line in rtw_mlme.c

[Greg KH]

On Sun, Jun 21, 2026 at 03:00:56PM +0000, Dalvin-Ehinoma Noah Aiguobas wrote:
> Move logical operators from continuation lines to the previous line
> to conform to the linux kernel coding style.
> 
> Signed-off-by: Dalvin-Ehinoma Noah Aiguobas <fliegbert2@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme.c | 23 +++++++++++------------
>  1 file changed, 11 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index 4fb74729180f..e3a17b5cbbf4 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -342,8 +342,8 @@ bool rtw_is_same_ibss(struct adapter *adapter, struct wlan_network *pnetwork)
>  
>  inline int is_same_ess(struct wlan_bssid_ex *a, struct wlan_bssid_ex *b)
>  {
> -	return (a->ssid.ssid_length == b->ssid.ssid_length)
> -		&&  !memcmp(a->ssid.ssid, b->ssid.ssid, a->ssid.ssid_length);
> +	return (a->ssid.ssid_length == b->ssid.ssid_length) &&
> +		!memcmp(a->ssid.ssid, b->ssid.ssid, a->ssid.ssid_length);
>  }
>  
>  int is_same_network(struct wlan_bssid_ex *src, struct wlan_bssid_ex *dst, u8 feature)
> @@ -751,8 +751,8 @@ void rtw_surveydone_event_callback(struct adapter	*adapter, u8 *pbuf)
>  		}
>  	} else {
>  		if (rtw_chk_roam_flags(adapter, RTW_ROAM_ACTIVE)) {
> -			if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)
> -				&& check_fwstate(pmlmepriv, _FW_LINKED)) {
> +			if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) &&
> +			    check_fwstate(pmlmepriv, _FW_LINKED)) {
>  				if (rtw_select_roaming_candidate(pmlmepriv) == _SUCCESS) {
>  					receive_disconnect(adapter, pmlmepriv->cur_network.network.mac_address
>  						, WLAN_REASON_ACTIVE_ROAM);
> @@ -925,8 +925,7 @@ void rtw_scan_abort(struct adapter *adapter)
>  
>  	start = jiffies;
>  	pmlmeext->scan_abort = true;
> -	while (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY)
> -		&& jiffies_to_msecs(start) <= 200) {
> +	while (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) && jiffies_to_msecs(start) <= 200) {

While it's great you made this change, it doesn't match up with what you
wrote in the description of the patch :(

thanks,

greg k-h