RE: [PATCH char-misc v2] mei: lb: fix incorrect type in assignment
From: Usyskin, Alexander
Date: Tue Jul 07 2026 - 07:34:34 EST
> Subject: Re: [PATCH char-misc v2] mei: lb: fix incorrect type in assignment
>
> On Tue, Jul 07, 2026 at 10:47:42AM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Jul 07, 2026 at 10:21:42AM +0300, Andy Shevchenko wrote:
> > > On Tue, Jul 07, 2026 at 06:43:20AM +0000, Usyskin, Alexander wrote:
> > > > > On Mon, Jul 06, 2026 at 04:01:30PM +0300, Alexander Usyskin wrote:
>
> ...
>
> > > > > > Cc: stable@xxxxxxxxxxxxxxx
> > > > >
> > > > > Why cc: stable? It doesn't actually cause any functional change to the
> > > > > code at all, right? This isn't running on s390, or am I mistaken?
> > > >
> > > > This driver is for discrete graphics card, so it may run on non-x86 system,
> thus all conversions.
> > > >
> > > > I've been told that if there is Fixes: for commit that already in stable, I
> should cc: stable.
> > > > If it is not hard rule, I'll drop cc: from the next patch revision.
> > >
> > > Cc'ing stable@ is a rule which is documented in-tree. Many developers just
> omit
> > > it for unknown reasons.
> >
> > My point is that this is NOT an actual bugfix that needs to be applied
> > anywhere except during the next merge window, as all it does is make
> > sparse quiet (which is a valid change). It doesn't do anything "real"
> > as this hardware is not on any big-endian systems.
>
> I was not objecting that. My comment was regarding to "if it's not a hard
> rule".
>
> > Please don't send stuff to stable that does not actually need to be in a
> > stable kernel tree.
>
> Fully agree.
>
Bottom line: it is hard rule, but not for such unimportant patch.
I'll drop cc in v3.
Should I also drop Fixes: line?
- -
Thanks,
Sasha