Re: [PATCH] staging: rtl8723bs: hal: remove unnecessary braces

[Greg KH]

On Mon, Jun 22, 2026 at 01:17:19PM +0000, Xiaofeng Yuan wrote:
> checkpatch reports two warnings about unnecessary braces in hal_intf.c:
> 
>  - WARNING: braces {} are not necessary for any arm of this
>    statement (rtw_hal_update_ra_mask)
>  - WARNING: braces {} are not necessary for single statement
>    blocks (rtw_hal_dm_watchdog_in_lps)
> 
> Both blocks contain only single statements, so the braces are
> redundant. Remove them to align with kernel coding style.
> 
> Compile tested with CONFIG_RTL8723BS=m.
> 
> Signed-off-by: Xiaofeng Yuan <xiaofengmian@xxxxxxx>
> ---
>  drivers/staging/rtl8723bs/hal/hal_intf.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
> index 27c0c0198..45634b5e5 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_intf.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
> @@ -208,9 +208,8 @@ void rtw_hal_update_ra_mask(struct sta_info *psta, u8 rssi_level)
>  
>  	if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true)
>  		add_ratid(padapter, psta, rssi_level);
> -	else {
> +	else
>  		UpdateHalRAMask8723B(padapter, psta->mac_id, rssi_level);
> -	}
>  }
>  
>  void rtw_hal_add_ra_tid(struct adapter *padapter, u32 bitmap, u8 *arg, u8 rssi_level)
> @@ -254,9 +253,8 @@ void rtw_hal_dm_watchdog(struct adapter *padapter)
>  
>  void rtw_hal_dm_watchdog_in_lps(struct adapter *padapter)
>  {
> -	if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode) {
> +	if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode)
>  		rtl8723b_HalDmWatchDog_in_LPS(padapter); /* this function caller is in interrupt context */
> -	}
>  }
>  
>  void beacon_timing_control(struct adapter *padapter)
> -- 
> 2.43.0
> 
> 

Does not apply to the latest tree :(