Re: [PATCH v2 1/3] staging: rtl8723bs: add spaces around operators in rtl8723b_cmd.c

[Greg KH]

On Fri, Jun 19, 2026 at 01:15:58PM -0700, Kai Cheng Jin wrote:
> Add missing spaces around arithmetic and bitwise operators to
> follow kernel coding style, as reported by checkpatch.pl.
> 
> Signed-off-by: Kai Cheng Jin <kj@xxxxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 88 ++++++++++----------
>  1 file changed, 44 insertions(+), 44 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> index c35c7f1c38ef..d92dde57b720 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> @@ -70,23 +70,23 @@ s32 FillH2CCmd8723B(struct adapter *padapter, u8 ElementID, u32 CmdLen, u8 *pCmd
>  			goto exit;
>  
>  		if (CmdLen <= 3)
> -			memcpy((u8 *)(&h2c_cmd)+1, pCmdBuffer, CmdLen);
> +			memcpy((u8 *)(&h2c_cmd) + 1, pCmdBuffer, CmdLen);
>  		else {
> -			memcpy((u8 *)(&h2c_cmd)+1, pCmdBuffer, 3);
> -			memcpy((u8 *)(&h2c_cmd_ex), pCmdBuffer+3, CmdLen-3);
> -/* 			*(u8 *)(&h2c_cmd) |= BIT(7); */
> +			memcpy((u8 *)(&h2c_cmd) + 1, pCmdBuffer, 3);
> +			memcpy((u8 *)(&h2c_cmd_ex), pCmdBuffer + 3, CmdLen - 3);
> +/*			*(u8 *)(&h2c_cmd) |= BIT(7); */

What changed on this last line?  That shouldn't have happened :(