Re: [PATCH v2] staging: rtl8723bs: remove unused function declarations

From: Greg KH

Date: Tue Jul 07 2026 - 07:43:36 EST


On Mon, Jun 22, 2026 at 06:34:53PM +0530, Aditya Chari wrote:
> rtl8192c_translate_rx_signal_stuff() and rtl8192c_query_rx_desc_status()
> are declared in rtl8192c_recv.h but have no implementation and no
> caller anywhere in the kernel tree. They are leftover from when this
> driver was derived from Realtek's shared vendor codebase covering
> multiple chip families.
>
> Verified via grep across the full tree that neither symbol is
> referenced outside this declaration, and confirmed via a full build
> of the module before and after removal that no warnings or errors
> are introduced.
>
> This addresses the "find and remove any code for other chips that is
> left over" item in the driver's TODO file.
>
> Signed-off-by: Aditya Chari <adi25charis@xxxxxxxxx>
> ------------------------------------------------------------------

This line isn't needed because:

>
> Changes since v1:
> - Rebased onto linux-next as requested by Dan Carpenter

That should go below

> ---

That line.

I think the documentation explains this, right?

thanks,

greg k-h