Re: [PATCH net-next v5 3/8] r8169: add support for phylink

[Maxime Chevallier]

On 7/7/26 11:16, javen wrote:
> From: Javen Xu <javen_xu@xxxxxxxxxxxxxx>
> 
> Transfer old framework to phylink. Phylink can support fiber mode card
> which can not get link status or link speed from standard phy registers.
> 
> Signed-off-by: Javen Xu <javen_xu@xxxxxxxxxxxxxx>
> ---
> Changes in v2:
>  - merge patch v1 3/6 and v1 4/6.
>  - add helper rtl_mac_enable_tx_lpi(), rtl_mac_disable_tx_lpi()
>    and rtl8169_get_lpi_caps()
> 
> Changes in v3:
>  - use phylink_ethtool_set_pauseparam to set pause status when change
>    mtu
>  - replace phy_do_ioctl_running with rtl8169_ioctl
>  - recover phy_mode according to tp->supports_gmii for 1G nics
> 
> Changes in v4:
>  - set lpi_interface if support eee
>  - Only if jumbo changes, set pause
> 
> Changes in v5:
>  - no changes
> ---
>  drivers/net/ethernet/realtek/Kconfig      |   1 +
>  drivers/net/ethernet/realtek/r8169_main.c | 279 ++++++++++++++++------
>  2 files changed, 206 insertions(+), 74 deletions(-)
> 
> diff --git a/drivers/net/ethernet/realtek/Kconfig b/drivers/net/ethernet/realtek/Kconfig
> index 9b0f4f9631db..49ac72734225 100644
> --- a/drivers/net/ethernet/realtek/Kconfig
> +++ b/drivers/net/ethernet/realtek/Kconfig
> @@ -88,6 +88,7 @@ config R8169
>  	select CRC32
>  	select PHYLIB

PHYLINK selects PHYLIB, you can therefore drop this.

Besides this and potential reworks for the pause, this patch looks
pretty good :)

Maxime