Re: [PATCH v2 4/4] arm64: dts: qcom: hamoa-pmics: Add ADC support

[Jishnu Prakash]

Hi Konrad,

On 6/30/2026 5:31 PM, Konrad Dybcio wrote:
> On 6/14/26 10:05 AM, Jishnu Prakash wrote:
>> From: Ayyagari Ushasreevalli <aushasre@xxxxxxxxxxxxxxxx>
>>
>> Add ADC node and define channels for:
>> - Die temperature for PMK8550, PM8550VE* and PMC8380* PMICs.
>> - PM8550: Die temperature, VPH power, and system thermistors.
>>
>> Define thermal zones 'sys-0-thermal' through 'sys-6-thermal' which
>> correspond to the off-PMIC system thermistors connected via
>> PM8550 AMUX/GPIO lines.
>>
>> Also,add io-channels and io-channel-names properties to the
>> temp_alarm nodes so that they can get temperature reading
>> from the ADC die_temp channels.
>>
>> Signed-off-by: Ayyagari Ushasreevalli <aushasre@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx>
>> ---
> 
> [...]
> 
>> +		sys-0-thermal {
>> +			polling-delay-passive = <0>;
> 
> Drop, this is zero by default
> 
>> +			thermal-sensors = <&pmk8550_vadc ADC5_GEN3_AMUX1_GPIO_100K_PU(1)>;
>> +			trips {
> 
> Please add a \n between the last property and the following subnode
> 
> 
>>  		pmc8380_6_gpios: gpio@8800 {
>> @@ -451,6 +697,8 @@ pm8550ve_8_temp_alarm: temp-alarm@a00 {
>>  			reg = <0xa00>;
>>  			interrupts = <0x8 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
>>  			#thermal-sensor-cells = <0>;
>> +			io-channels = <&pmk8550_vadc ADC5_GEN3_DIE_TEMP(8)>;
>> +			io-channel-names = "thermal";
>>  		};
> 
> pmc8380_6 isn't mounted on purwa boards - do we need to override the
> channel definitions in the vadc?

Thanks for catching that, I now see that pmc8380_6-related nodes are
disabled for Purwa. I think the pmc8380_6 ADC channel definition can
also be deleted using /delete-node/ for Purwa. If this is fine, I'll
make this change in the next patch series. I'll also address your
other comments there.

Thanks,
Jishnu

> 
> Konrad