Re: [PATCH] rust: irq: make Registration compatible with lifetime-bound drivers

[Daniel Almeida]

> On 3 Jul 2026, at 18:09, Danilo Krummrich <dakr@xxxxxxxxxx> wrote:
> 
> Adapt the IRQ registration to work with the Higher-Ranked Lifetime Types
> (HRT) device driver architecture introduced in commit 2c7c65933600
> ("Merge patch series "rust: device: Higher-Ranked Lifetime Types for
> device drivers"").
> 
> With HRT, driver structs carry a lifetime parameter tied to the device
> binding scope, allowing device resources such as pci::Bar<'bar> to be
> held directly rather than through Devres indirection. However, the IRQ
> abstraction required Handler: Sync + 'static, preventing handlers from
> embedding lifetime-parameterized resources.
> 
> Remove the 'static bound from Handler and ThreadedHandler and replace
> the Devres<RegistrationInner> indirection with direct request_irq() /
> free_irq() calls in the constructor and PinnedDrop.  Registration<'a, T>
> stores the IrqRequest<'a>, which structurally ties it to the device
> binding scope.
> 
> Also remove the &Device<Bound> parameter from the handler callbacks,
> since handlers that need device access can embed it in their own type.
> 
> IRQ handlers can now directly own device resources:
> 
> struct IrqHandler<'irq> {
>    bar: pci::Bar<'irq, BAR_SIZE>,
> }
> 
> impl irq::Handler for IrqHandler<'_> {
>    fn handle(&self) -> IrqReturn {
>        let stat = self.bar.read(regs::STAT);
>        ...
>    }
> }
> 
> This eliminates the indirection previously required for IRQ handlers to
> access device resources and aligns with the broader goal of expressing
> every registration scoped to a driver binding through compile-time
> lifetime bounds.
> 
> Signed-off-by: Danilo Krummrich <dakr@xxxxxxxxxx>
> 

Reviewed-by: Daniel Almeida <daniel.almeida@xxxxxxxxxxxxx>