RE: [PATCH net-next 01/15] net/mlx5e: psp: Rename the saved psp_dev to 'psd'

From: Loktionov, Aleksandr

Date: Tue Jul 07 2026 - 10:14:43 EST




> -----Original Message-----
> From: Tariq Toukan <tariqt@xxxxxxxxxx>
> Sent: Tuesday, July 7, 2026 3:09 PM
> To: Andrew Lunn <andrew+netdev@xxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; Paolo Abeni
> <pabeni@xxxxxxxxxx>
> Cc: Loktionov, Aleksandr <aleksandr.loktionov@xxxxxxxxx>; Boris
> Pismenny <borisp@xxxxxxxxxx>; Chris Mi <cmi@xxxxxxxxxx>; Cosmin, Ratiu
> <cratiu@xxxxxxxxxx>; Daniel Zahka <daniel.zahka@xxxxxxxxx>; Dragos
> Tatulea <dtatulea@xxxxxxxxxx>; Gal Pressman <gal@xxxxxxxxxx>; Keller,
> Jacob E <jacob.e.keller@xxxxxxxxx>; Jianbo Liu <jianbol@xxxxxxxxxx>;
> Lama Kayal <lkayal@xxxxxxxxxx>; Leon Romanovsky <leon@xxxxxxxxxx>;
> linux-kernel@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; Mark Bloch
> <mbloch@xxxxxxxxxx>; Raed Salem <raeds@xxxxxxxxxx>; Rahul Rameshbabu
> <rrameshbabu@xxxxxxxxxx>; Saeed Mahameed <saeedm@xxxxxxxxxx>;
> Stanislav Fomichev <sdf@xxxxxxxxxxx>; Stanislav Fomichev
> <sdf.kernel@xxxxxxxxx>; Tariq Toukan <tariqt@xxxxxxxxxx>; Willem de
> Bruijn <willemdebruijn.kernel@xxxxxxxxx>
> Subject: [PATCH net-next 01/15] net/mlx5e: psp: Rename the saved
> psp_dev to 'psd'
>
> From: Cosmin Ratiu <cratiu@xxxxxxxxxx>
>
> This is the canonical name used in the core, so try to be consistent.
> No-op change.
>
> Signed-off-by: Cosmin Ratiu <cratiu@xxxxxxxxxx>
> Reviewed-by: Dragos Tatulea <dtatulea@xxxxxxxxxx>
> Signed-off-by: Tariq Toukan <tariqt@xxxxxxxxxx>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c | 8 ++++---
> -
> drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.h | 2 +-
> .../net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.c | 2 +-
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c
> index d9adb993e64d..4f2fa6756b82 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c
> @@ -1072,11 +1072,11 @@ void mlx5e_psp_unregister(struct mlx5e_priv
> *priv) {
> struct mlx5e_psp *psp = priv->psp;
>
> - if (!psp || !psp->psp)
> + if (!psp || !psp->psd)
> return;
>
> - psp_dev_unregister(psp->psp);
> - psp->psp = NULL;
> + psp_dev_unregister(psp->psd);
> + psp->psd = NULL;
> }
>
> void mlx5e_psp_register(struct mlx5e_priv *priv) @@ -1100,7 +1100,7
> @@ void mlx5e_psp_register(struct mlx5e_priv *priv)
> psd);
> return;
> }
> - psp->psp = psd;
> + psp->psd = psd;
> }
>
> int mlx5e_psp_init(struct mlx5e_priv *priv) diff --git
> a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.h
> b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.h
> index 6b62fef0d9a7..a53f90f7c341 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.h
> @@ -23,7 +23,7 @@ struct mlx5e_psp_stats { };
>
> struct mlx5e_psp {
> - struct psp_dev *psp;
> + struct psp_dev *psd;
> struct psp_dev_caps caps;
> struct mlx5e_psp_fs *fs;
> atomic_t tx_key_cnt;
> diff --git
> a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.c
> index ef7f5338540f..c2f9899d23a5 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp_rxtx.c
> @@ -124,7 +124,7 @@ bool mlx5e_psp_offload_handle_rx_skb(struct
> net_device *netdev, struct sk_buff * {
> u32 psp_meta_data = be32_to_cpu(cqe->ft_metadata);
> struct mlx5e_priv *priv = netdev_priv(netdev);
> - u16 dev_id = priv->psp->psp->id;
> + u16 dev_id = priv->psp->psd->id;
> bool strip_icv = true;
> u8 generation = 0;
>
> --
> 2.44.0

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>