RE: [PATCH net-next 03/15] net/mlx5e: psp: Remove unneeded ref counting for PSP steering

From: Loktionov, Aleksandr

Date: Tue Jul 07 2026 - 10:20:12 EST




> -----Original Message-----
> From: Tariq Toukan <tariqt@xxxxxxxxxx>
> Sent: Tuesday, July 7, 2026 3:09 PM
> To: Andrew Lunn <andrew+netdev@xxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub
> Kicinski <kuba@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; Paolo Abeni
> <pabeni@xxxxxxxxxx>
> Cc: Loktionov, Aleksandr <aleksandr.loktionov@xxxxxxxxx>; Boris
> Pismenny <borisp@xxxxxxxxxx>; Chris Mi <cmi@xxxxxxxxxx>; Cosmin, Ratiu
> <cratiu@xxxxxxxxxx>; Daniel Zahka <daniel.zahka@xxxxxxxxx>; Dragos
> Tatulea <dtatulea@xxxxxxxxxx>; Gal Pressman <gal@xxxxxxxxxx>; Keller,
> Jacob E <jacob.e.keller@xxxxxxxxx>; Jianbo Liu <jianbol@xxxxxxxxxx>;
> Lama Kayal <lkayal@xxxxxxxxxx>; Leon Romanovsky <leon@xxxxxxxxxx>;
> linux-kernel@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; Mark Bloch
> <mbloch@xxxxxxxxxx>; Raed Salem <raeds@xxxxxxxxxx>; Rahul Rameshbabu
> <rrameshbabu@xxxxxxxxxx>; Saeed Mahameed <saeedm@xxxxxxxxxx>;
> Stanislav Fomichev <sdf@xxxxxxxxxxx>; Stanislav Fomichev
> <sdf.kernel@xxxxxxxxx>; Tariq Toukan <tariqt@xxxxxxxxxx>; Willem de
> Bruijn <willemdebruijn.kernel@xxxxxxxxx>
> Subject: [PATCH net-next 03/15] net/mlx5e: psp: Remove unneeded ref
> counting for PSP steering
>
> From: Cosmin Ratiu <cratiu@xxxxxxxxxx>
>
> PSP steering uses reference counting for TX and RX steering tables,
> but there's only a single reference for each acquired and thus the
> reference counting is unnecessary.
>
> Remove it and consolidate functions to simplify the code.
>
> Signed-off-by: Cosmin Ratiu <cratiu@xxxxxxxxxx>
> Reviewed-by: Dragos Tatulea <dtatulea@xxxxxxxxxx>
> Signed-off-by: Tariq Toukan <tariqt@xxxxxxxxxx>
> ---
> .../mellanox/mlx5/core/en_accel/psp.c | 129 +++++------------
> -
> 1 file changed, 33 insertions(+), 96 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c
> b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c
> index d4686b5af776..a69c4e2821e9 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c
> @@ -26,7 +26,6 @@ struct mlx5e_psp_tx {
> struct mlx5_flow_table *ft;
> struct mlx5_flow_group *fg;
> struct mlx5_flow_handle *rule;

...

> }
>
> static void mlx5e_accel_psp_fs_cleanup(struct mlx5e_psp_fs *fs)
> --
> 2.44.0

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>