Re: [PATCH] ALSA: control: preserve snd_card_file_add() error code in snd_ctl_open()

[Takashi Iwai]

On Tue, 07 Jul 2026 11:09:58 +0200,
phucduc.bui@xxxxxxxxx wrote:
> 
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
> 
> snd_ctl_open() unconditionally overwrites the return value of
> snd_card_file_add() with -ENODEV on failure, discarding the actual
> error code.
> This also preserves the original error code returned by
> snd_card_file_add() (e.g. -ENOMEM or -ENODEV), instead of
> unconditionally overwriting it with -ENODEV.
> No functional change other than the returned error code in this
> failure path.
> 
> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
> ---
>  sound/core/control.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/core/control.c b/sound/core/control.c
> index 0ca9fff56e51..f64b2dec746a 100644
> --- a/sound/core/control.c
> +++ b/sound/core/control.c
> @@ -64,7 +64,6 @@ static int snd_ctl_open(struct inode *inode, struct file *file)
>  	}
>  	err = snd_card_file_add(card, file);
>  	if (err < 0) {
> -		err = -ENODEV;
>  		goto __error1;
>  	}

Please drop superfluous braces, too, as it becomes a single-line now.


thanks,

Takashi