Re: [PATCH 3/4] tty: serial: men_z135_uart: replace __get_free_page() with kmalloc()

[Greg Kroah-Hartman]

On Fri, May 29, 2026 at 10:52:49AM +0200, Jiri Slaby wrote:
> On 29. 05. 26, 10:43, Mike Rapoport wrote:
> > On Fri, May 29, 2026 at 09:47:33AM +0200, Jiri Slaby wrote:
> > > On 28. 05. 26, 12:24, Mike Rapoport (Microsoft) wrote:
> > > > men_z135_probe() allocates a receive staging buffer filled by the
> > > > CPU via memcpy_fromio() from the device MMIO region.
> > > > 
> > > > This buffer can be allocated with kmalloc() as there's nothing special
> > > > about it to go directly to the page allocator.
> > > > 
> > > > kmalloc() provides a better API that does not require ugly casts and
> > > > kfree() does not need to know the size of the freed object.
> > > > 
> > > > Replace use of __get_free_page() with kmalloc() and free_page() with
> > > > kfree().
> > > > 
> > > > Link: https://lore.kernel.org/all/635405e4-9423-4a25-a6e7-e03c8ea0bcbe@xxxxxxxxxx
> > > > Signed-off-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
> > > > ---
> > > >    drivers/tty/serial/men_z135_uart.c | 7 ++++---
> > > >    1 file changed, 4 insertions(+), 3 deletions(-)
> > > > 
> > > > diff --git a/drivers/tty/serial/men_z135_uart.c b/drivers/tty/serial/men_z135_uart.c
> > > > index 6fad57fee912..9c32b01edc9e 100644
> > > > --- a/drivers/tty/serial/men_z135_uart.c
> > > > +++ b/drivers/tty/serial/men_z135_uart.c
> > > > @@ -17,6 +17,7 @@
> > > >    #include <linux/bitops.h>
> > > >    #include <linux/mcb.h>
> > > > +#include <linux/slab.h>
> > > >    #define MEN_Z135_MAX_PORTS		12
> > > 
> > > This one is misplaced.
> > 
> > Do you mean an empty line is missing? Or there's particular order of
> > includes here?
> 
> You added it after an empty line -- along to #defines. You should had added
> it along #includes instead -- before the empty line.

I've fixed it up when applying it, thanks.

greg k-h