Re: [PATCH v2 1/2] dt-bindings: clock: ultrarisc: Add DP1000 Clock Controller
From: Brian Masney
Date: Tue Jul 07 2026 - 15:44:41 EST
Hi Krzysztof / Conor,
On Wed, Jun 17, 2026 at 02:02:54PM +0800, Jia Wang wrote:
> diff --git a/include/dt-bindings/clock/ultrarisc,dp1000-clk.h b/include/dt-bindings/clock/ultrarisc,dp1000-clk.h
> new file mode 100644
> index 000000000000..751125f99965
> --- /dev/null
> +++ b/include/dt-bindings/clock/ultrarisc,dp1000-clk.h
> @@ -0,0 +1,27 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +#ifndef _DT_BINDINGS_CLOCK_ULTRARISC_DP1000_CLK_H
> +#define _DT_BINDINGS_CLOCK_ULTRARISC_DP1000_CLK_H
> +
> +#define DP1000_CLK_SYSPLL 0
> +#define DP1000_CLK_SYSPLL_DIV2 1
> +#define DP1000_CLK_SUBSYS 2
> +#define DP1000_CLK_GMAC 3
> +#define DP1000_CLK_UART_ROOT 4
> +#define DP1000_CLK_I2C_ROOT 5
> +#define DP1000_CLK_SPI_ROOT 6
> +#define DP1000_CLK_PCIE_DBI 7
> +#define DP1000_CLK_PCIEX4_CORE 8
> +#define DP1000_CLK_PCIEX16_CORE 9
> +#define DP1000_CLK_PCIE_AUX 10
> +#define DP1000_CLK_UART0 11
> +#define DP1000_CLK_UART1 12
> +#define DP1000_CLK_UART2 13
> +#define DP1000_CLK_UART3 14
> +#define DP1000_CLK_I2C0 15
> +#define DP1000_CLK_I2C1 16
> +#define DP1000_CLK_I2C2 17
> +#define DP1000_CLK_I2C3 18
> +#define DP1000_CLK_SPI0 19
> +#define DP1000_CLK_SPI1 20
A common scenario for the driver side is that it needs to know how many
clocks are present. For example, the driver in this series has the
following in drivers/clk/ultrarisc/clk-dp1000.c:
#define DP1000_CLK_NUM 21
Which seems a bit fragile to me having it in a separate file.
I've seen where some dt-bindings will have the define right below the
last clock, so DP1000_CLK_SPI1 in this particular case.
There are a few clock dt-bindings that have it this way. For example,
see include/dt-bindings/clock/nuvoton,npcm7xx-clock.h. Personally, I
prefer it this way, however I can see where the argument could be made
that this doesn't belong in the dt-bindings.
Do you have guidance for what you'd like to see?
Brian