Re: [PATCH v2 2/2] ARM: dts: aspeed: Add NVIDIA VR-NVL BMC

[Jacky Huang]

On Mon, Jul 06, 2026 at 10:24:00AM +0000, sashiko-bot wrote:
> [Severity: High]
> Does this incorrectly nest cp2112a inside an interface@1 node?
>
> The CP2112 is a single-interface USB Class 0 device. According to the USB
> device tree bindings and the kernel's usb_of_has_combined_node() logic,
> shouldn't this be defined as a standalone device node directly on device@1,
> similar to how cp2112c and cp2112g are defined?
>
> By nesting cp2112a inside interface@1 with reg = <1 1> (specifying interface
> 1 when the CP2112 only has interface 0), it seems the USB subsystem will
> fail to match the OF node to the device. Could this cause the
> gpio-controller and interrupt-controller properties to be ignored?

This was already addressed in the v1 thread. cp2112a and cp2112b are
NVIDIA composite devices that expose 3 USB interfaces, so
usb_of_has_combined_node() returns false and interface@1 is used.

> [Severity: High]
> Are the properties for cp2112b also incorrectly nested in an interface@1
> child node here?
>
> Similar to cp2112a above, defining this inside an interface node rather than
> directly on device@1 could prevent the USB core from attaching the OF nodes
> to the instantiated devices, silently breaking GPIO and interrupt control.

Same as above for cp2112b. No change is needed.

Jacky