Re: [PATCH v3 2/2] media: i2c: hm1092: add Himax HM1092 mono NIR sensor driver

[Sakari Ailus]

Hi Ramshouriesh,

On Sun, Jul 05, 2026 at 01:01:13AM +0530, Ramshouriesh R wrote:
> Hi Sakari,
> 
> Small correction: my name is Ramshouriesh. You can address me as Ram.

My apologies for that, there apparently were quite a few letters missing. I
hope that wasn't the case with the review.

> 
> Thanks for the review. I’ll address the comments in the next revision.
> 
> However regarding the mode names, there is no proper datasheet for
> this sensor released publicly.
> I will add the proper mode names based on what the camera does in each mode.
> 
> And regarding the driver supporting single data lane, I will make
> data-lanes optional and
> will initialize the endpoint parser with a default of one data lane
> and configurations
> explicitly specifying anything other than one lane will be rejected.
> The binding will retain an optional constraint permitting only <1>, so
> an explicit invalid
> value will be caught by schema validation, but data-lanes will be
> omitted from the example.

Please just drop the data-lanes property altogether: the DT is intended to
convey the board, generally what's not discoverable or otherwise known, to
software, and there's nothing to configure here.

And one more thing. Could you add the selection rectangles and possibly
other API elements required by libcamera
<URL:https://docs.libcamera.org/master/sensor_driver_requirements.html>?

-- 
Kind regards,

Sakari Ailus