Re: [PATCH] dt-bindings: net: convert microchip,lan78xx.txt to YAML schema

[Krzysztof Kozlowski]

On Tue, Jul 07, 2026 at 10:58:40PM +0600, Mikhail Lukianchikov wrote:
> Convert the Microchip LAN78xx family (LAN7800, LAN7801, LAN7850) binding
> documentation from plain text to DT schema format using YAML.

Subject: there is no YAML schema

https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23

> 
> The conversion was validated with 'make dt_binding_check'

Drop, irrelevant and not even true. There is no point in writing in
commit msg that you performed the absolute minimal expected build
testing. It is expected.


> 
> Signed-off-by: Mikhail Lukianchikov <avermoal@xxxxxxxxx>

...

You left stale maintainer entry. Checkpatch told you that, no? Did you
run checkpatch?

If this is your first contribution then you need to read carefully
guidelines how to contribute and then actually follow these guidelines.
What does evry guideline speak about? Checkpatch.

> diff --git a/Documentation/devicetree/bindings/net/microchip,lan78xx.yaml b/Documentation/devicetree/bindings/net/microchip,lan78xx.yaml
> new file mode 100644
> index 000000000000..743667c1e761
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/microchip,lan78xx.yaml


microchip,lan7800.yaml

> @@ -0,0 +1,113 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/microchip,lan78xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip LAN78xx Gigabit Ethernet controller
> +
> +maintainers:
> +  - Rengarajan Sundararajan <Rengarajan.S@xxxxxxxxxxxxx>
> +  - UNGLinuxDriver <UNGLinuxDriver@xxxxxxxxxxxxx>

Drop last email.

> +
> +description:
> +  The LAN78XX devices are usually configured by programming their OTP or with
> +  an external EEPROM, but some platforms (e.g. Raspberry Pi 3 B+) have neither.
> +  The Device Tree properties, if present, override the OTP and EEPROM.
> +
> +allOf:
> +  - $ref: /schemas/usb/usb-device.yaml#
> +  - $ref: /schemas/net/ethernet-controller.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - usb424,7800
> +      - usb424,7801
> +      - usb424,7850

Odd format. Missing blank lines. Look at existing code to understand how
this is supposed to look like.

> +  reg:
> +    maxItems: 1
> +    description: USB port number
> +  local-mac-address:
> +    $ref: /schemas/types.yaml#/definitions/uint8-array
> +    minItems: 6
> +    maxItems: 6
> +    description:
> +      MAC address to use if not stored in OTP or EEPROM. If present,
> +      overrides OTP/EEPROM.
> +  mdio:
> +    $ref: /schemas/net/mdio.yaml#
> +    unevaluatedProperties: false
> +
> +patternProperties:
> +  "^ethernet-phy(@[0-9a-f]+)?$":
> +    type: object
> +    description: |
> +      PHY node for the embedded or external PHY. The PHY address is
> +      given by the 'reg' property.
> +    properties:
> +      reg:
> +        maxItems: 1
> +        description: PHY address.
> +      microchip,led-modes:
> +        $ref: /schemas/types.yaml#/definitions/uint32-array
> +        minItems: 1
> +        maxItems: 4
> +        description:
> +          Array of LED mode values for each of up to 4 LEDs.
> +          Omitted LEDs are turned off. Allowed values are defined
> +          in include/dt-bindings/net/microchip-lan78xx.h.
> +    required:
> +      - reg
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/net/microchip-lan78xx.h>
> +    / {
> +        usb: usb {
> +            compatible = "usb-host";
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +        };
> +    };
> +    &usb {

Drop all this, irrelevant and not even close to expected style.

> +        usb-port@1 {
> +            compatible = "usb424,2514";

Drop node

> +            reg = <1>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            usb-port@1 {
> +                compatible = "usb424,2514";

Drop node, not relevant to this binding.

Again, look at other bindings to understand what to write. Or read
DTS101 slides.

> +                reg = <1>;
> +                #address-cells = <1>;
> +                #size-cells = <0>;

Best regards,
Krzysztof