Re: [PATCH v5 08/19] clk: qcom: dispcc-qcm2290: Set HW_CTRL_TRIGGER flag for GDSC

[Imran Shaik]

On 03-07-2026 12:54 pm, Konrad Dybcio wrote:
> On 7/2/26 8:31 PM, Imran Shaik wrote:
> > Set HW_CTRL_TRIGGER flag for the MDSS GDSC to provide dynamic control to
> > switch the GDSC HW and SW modes at runtime.
> >
> > Signed-off-by: Imran Shaik <imran.shaik@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/clk/qcom/dispcc-qcm2290.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/qcom/dispcc-qcm2290.c b/drivers/clk/qcom/dispcc-qcm2290.c
> > index 6f8c21f05ba4536d45c2a609d152f871cb875bbb..89a6cdd26217381cd44a515766363cf94d0aaeeb 100644
> > --- a/drivers/clk/qcom/dispcc-qcm2290.c
> > +++ b/drivers/clk/qcom/dispcc-qcm2290.c
> > @@ -467,7 +467,7 @@ static struct gdsc mdss_gdsc = {
> >   		.name = "mdss_gdsc",
> >   	},
> >   	.pwrsts = PWRSTS_OFF_ON,
> > -	.flags = HW_CTRL,
> > +	.flags = HW_CTRL_TRIGGER,
>
> No other dispcc driver sets this (other than kaanapali). Downstream uses
> this for when DISP RSC (which agatti doesn't have [1]) is supposed to
> idle
>
> Konrad
>
> [1] (well maybe it does but there's no RPMH so essentially it's not there)

Sure, will drop this change in the next series.

Thanks,
Imran