Re: [PATCH v1 1/2] dt-bindings: pinctrl: qcom,milos-lpass-lpi-pinctrl: Add Eliza pinctrl

[Ravi Hothi]

On 7/7/2026 7:01 PM, Rob Herring (Arm) wrote:
> On Fri, 03 Jul 2026 13:00:28 +0530, Ravi Hothi wrote:
> > Document compatible for Qualcomm Eliza SoC LPASS LPI pin controller.
> > Eliza has the same pin mux functions as Milos but uses a different
> > slew rate register layout where the slew rate field is in the same
> > GPIO config register rather than a separate dedicated register. As a
> > result, Eliza only has a single reg entry instead of two.
> >
> > Signed-off-by: Ravi Hothi <ravi.hothi@xxxxxxxxxxxxxxxx>
> > ---
> >   .../pinctrl/qcom,milos-lpass-lpi-pinctrl.yaml | 22 +++++++++++++++----
> >   1 file changed, 18 insertions(+), 4 deletions(-)
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/qcom,milos-lpass-lpi-pinctrl.yaml: properties:compatible:oneOf: [{'const': 'qcom,milos-lpass-lpi-pinctrl'}, {'const': 'qcom,eliza-lpass-lpi-pinctrl'}] should not be valid under {'items': {'propertyNames': {'const': 'const'}, 'required': ['const']}}
> 	hint: Use 'enum' rather than 'oneOf' + 'const' entries
> 	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.kernel.org/project/devicetree/patch/20260703073029.2588960-2-ravi.hothi@xxxxxxxxxxxxxxxx
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.

ACK, Will update in next version.

Thanks,
Ravi Hothi