Re: [PATCH] mshv: fix fd leak in mshv_ioctl_create_vtl()
From: Hamza Mahfooz
Date: Wed Jul 08 2026 - 09:05:28 EST
On Wed, Jul 08, 2026 at 09:28:52AM +0800, Yi Xie wrote:
> put_unused_fd() if anon_inode_getfile() fails.
>
> Signed-off-by: Yi Xie <xieyi@xxxxxxxxxx>
Reviewed-by: Hamza Mahfooz <hamzamahfooz@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/hv/mshv_vtl_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hv/mshv_vtl_main.c b/drivers/hv/mshv_vtl_main.c
> index 0d3d4161974f..897a41b08d02 100644
> --- a/drivers/hv/mshv_vtl_main.c
> +++ b/drivers/hv/mshv_vtl_main.c
> @@ -129,6 +129,7 @@ mshv_ioctl_create_vtl(void __user *user_arg, struct device *module_dev)
> file = anon_inode_getfile("mshv_vtl", &mshv_vtl_fops,
> vtl, O_RDWR);
> if (IS_ERR(file)) {
> + put_unused_fd(fd);
> kfree(vtl);
> return PTR_ERR(file);
> }
> --
> 2.34.1